Skip to content

Remove ZZ before tweak name#38

Open
ryannair05 wants to merge 1 commit intoLorenzoPane:masterfrom
ryannair05:patch-1
Open

Remove ZZ before tweak name#38
ryannair05 wants to merge 1 commit intoLorenzoPane:masterfrom
ryannair05:patch-1

Conversation

@ryannair05
Copy link
Copy Markdown

I fixed the conflict with Little11 so this is no longer needed

I fixed the conflict with Little11 so this is no longer needed
@LorenzoPane
Copy link
Copy Markdown
Owner

Thanks for the PR, and congrats on the update! One concern I have is wether it is likely someone else's tweak will cause the same conflict. Did you resolve the issue by changing the load order or did you find the underlying cause?

@ryannair05
Copy link
Copy Markdown
Author

I resolved the issue by making parts of the tweak only inject into the Springboard. The issue is with tweaks on iOS 13 that bring the iPhone X gestures, but according to the source code of HalFiPad the main competing tweak, this issue should not be there by default

@LorenzoPane
Copy link
Copy Markdown
Owner

LorenzoPane commented Aug 14, 2020

Thanks. I'll consider merging. I'm not positive yet, as it does't really do any harm in it's current state and it's preventing possible future conflicts. Particularly since we don't know precisely the interaction that was causing the bug in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants