MHWD support #2
MHWD support #2
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces initial MHWD (Manjaro Hardware Detection) support to the MCP project, implementing hardware driver management functionality. The changes include a complete refactoring of the driver management architecture, separating configuration queries from transaction building, and adding a new Qt/QML UI module for hardware configuration.
Key changes:
- Refactored
DriverManagerintoConfigProviderandDriverTransactionBuilderfor better separation of concerns - Added new
mcp-qt/mhwdmodule with QML UI components for hardware driver management - Introduced device categorization system (Graphics, Network, Audio, Storage, Input)
- Implemented CRTP-based device scanner template to reduce code duplication
- Updated CLI commands to use the new
ConfigProviderAPI
Reviewed changes
Copilot reviewed 56 out of 57 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packaging/PKGBUILD | Updated package installation to include new mhwd KCM plugin and QML modules |
| mcp.code-workspace | Added VS Code workspace configuration file |
| mcp-qt/mhwd/ui/*.qml | New QML UI components for hardware driver management interface |
| mcp-qt/mhwd/*.{h,cpp} | Core view models and data models for Qt/QML integration |
| mcp-qt/mhwd/kcm/* | KCM plugin integration for system settings |
| mcp-qt/mhwd/CMakeLists.txt | Build configuration for mhwd Qt module and standalone executable |
| mcp-qt/kernel/* | Renamed library from mcp-qt-page-kernel to mcp-qt-kernel |
| mcp-qt/CMakeLists.txt | Added mhwd subdirectory to build system |
| libmcp/mhwd/internal/udev/* | Refactored device scanners using CRTP pattern |
| libmcp/mhwd/*.{hpp,cpp} | Split DriverManager into ConfigProvider and DriverTransactionBuilder |
| libmcp/mhwd/Types.hpp | Moved public types from internal namespace to main API |
| libmcp/mhwd/Device.hpp | Restructured device API with nested types for better organization |
| cli/mhwd/* | Updated CLI commands to use new ConfigProvider API |
Comments suppressed due to low confidence (2)
mcp-qt/mhwd/ui/DeviceCard.qml:1
- Empty Behavior block with no easing type specified. Should either remove the empty line or specify an easing type for consistency with other Behavior blocks in the file.
mcp-qt/mhwd/ui/DeviceCard.qml:1 - Empty Behavior block with no easing type specified. Should either remove the empty line or specify an easing type for consistency with other Behavior blocks in the file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 72 out of 75 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (4)
mcp-qt/mhwd/ui/DriverItem.qml:1
- Debug console.log statement should be removed before merging to production. This type of logging pollutes the console output and provides no value in release builds.
mcp-qt/mhwd/ui/DeviceCard.qml:1 - Empty comment should be removed as it adds no value and clutters the code.
mcp-qt/common/qml/CMakeLists.txt:1 - Empty line added at end of file appears to be accidental and should be removed to maintain consistent file formatting.
libmcp/mhwd/internal/Device.cpp:1 - Line 5 has inconsistent comment formatting compared to the rest of the file. The closing comment marker should not have a trailing space to maintain consistency with other files in the codebase.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,97 @@ | |||
| pragma ComponentBehavior: Bound | |||
There was a problem hiding this comment.
Empty comment block between layout items serves no purpose and should be removed to keep the code clean.
No description provided.