Optimizations #375
Merged
Optimizations #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Most samples that touch these changes worked and tested an older android device down to API 31. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Did some Micro and Macro benchmarking to squeeze more performance out of methods that are called often.
The goal of this would be performance gains small or big, less memory allocations, and GC pressure from the zip/zstd classes.
Drafting this for now to make sure older android API's support these changes (like
in.read(x,y,z)). Along with some thorough testing in real time testing. So far this just passes JUnit testing.Some notes/thoughts:
A user was also using KV to read UserGameStatsSchema_1245620 using
tryLoadAsBinary()and with some benchmarking resulted in ~110ms on average. I'm sure this can be cut down considerably too.GameNative also utilizes ContentDownloader to download steam apps and KeyValue too to load users libraries and parse PICS (some very large) on Android, so any improvments for them is also a plus.
Checklist