Skip to content

Fix Movers Creation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LoneWanderer-GH wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix Movers Creation #1

LoneWanderer-GH wants to merge 7 commits into from

Conversation

@LoneWanderer-GH
Copy link
Owner

@LoneWanderer-GH LoneWanderer-GH commented Sep 2, 2018 •
edited
Loading

  • Registerer addon into ElvUI at a better suited moment of Wow loading process
  • At ElvUI plugin register time, try to create the movers
  • fancy console print logger
  • some modifications that could pave the way to a more generic addon (?)

@LoneWanderer-GH
Fix Movers Creation
f71c155 
- Registerer addon into ElvUI when WoW events PLAYER_ALIVE PLAYER_DEAD triggered
- At register time, try to create the movers
- several fixes (fancy console print logger)
@LoneWanderer-GH
Update ElvUI_CoolLine_Wrapper.toc
6599eb8
@LoneWanderer-GH
Update ElvUI_CoolLine_Wrapper.lua
53a0b8c 
Remove LUA error for table declaration
@LoneWanderer-GH
Add files via upload
e681e3a 
add concept screenshot
@LoneWanderer-GH
Update README.md
dddc8a1
@LoneWanderer-GH
Update README.md
6f98b28
@LoneWanderer-GH
Implementation updates
820940e 
- Put some more generic code to handle various addons and their frames (provided we can find the frame to handle ...)
- Revamped options part, however this is not very useful yet. Some keys could be stored better with an option hierarchy instead of all flat with generated key ;) (code related to Options is disabled things it does not really work)

Known issue(s):
- does not intercept the TomTom addon arrow frame. Maybe linked to the way things appear in the frame (late creation by TomTom addon ?)

Still to do:
- more addon options encapsulation ?
@LoneWanderer-GH LoneWanderer-GH self-assigned this Sep 6, 2018
@LoneWanderer-GH LoneWanderer-GH added bug Something isn't working enhancement New feature or request labels Sep 6, 2018
@LoneWanderer-GH LoneWanderer-GH mentioned this pull request Sep 6, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LoneWanderer-GH LoneWanderer-GH

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LoneWanderer-GH