Skip to content

Conversation

@amokan
Copy link
Contributor

@amokan amokan commented Jan 14, 2026

I found this gap while going through PR #3088 and PR #3089 again this morning.

So in PR #3069 - we introduced IngestEventQueue.list_counts_with_tids/1 and some reducer patterns that used the results from that function like {{sid_bid_pid, tid}, size}.
The next day in PR #3065 - we changed the return of list_counts_with_tids/1 to {table_key, size}, but did not update the reducer patterns. I then built upon those reducer patterns for the consolidated pipeline efforts.

This PR aligns the reducer patterns with the current return shape of {table_key, size}

Copy link
Contributor

@Ziinc Ziinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think there is a test that catches this code path, would be good to add that in @amokan , especially since #3088 seems to be passing

@Ziinc Ziinc merged commit 0f4cd9e into main Jan 15, 2026
8 checks passed
@Ziinc Ziinc deleted the amokan/bug-ingest-reducer-pattern-match branch January 15, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants