feat: add api for membership management #2821
Open
+192
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add and delete users from a team
…pattern-matching to better handle with clause
…are into etienne/admin-api-updates
Ziinc
requested changes
Oct 8, 2025
Contributor
Ziinc
left a comment
Ziinc
left a comment
There was a problem hiding this comment.
as discussed, would also need private:admin scope for pseudo rbac
| |> add_access_token(user, "private") | ||
| |> post(~p"/api/teams/#{main_team.token}/members", %{email: new_member.email}) | ||
| |> response(204) | ||
| |> assert_schema("AcceptedResponse") == "" |
Contributor
There was a problem hiding this comment.
should return created user, should also be a 201 since we're creating a team_user
Comment on lines
+245
to
+254
| test "returns not found if doesn't own the team", %{conn: conn, main_team: main_team} do | ||
| invalid_user = insert(:user) | ||
| new_member = insert(:user) | ||
|
|
||
| assert conn | ||
| |> add_access_token(invalid_user, "private") | ||
| |> post(~p"/api/teams/#{main_team.token}/members", %{email: new_member.email}) | ||
| |> json_response(404) | ||
| |> assert_schema("NotFoundResponse") == %{error: "Not Found"} | ||
| end |
Contributor
There was a problem hiding this comment.
401 would be more appropriate.
would also need a 400 test for bad team_user attrs
| end | ||
| end | ||
|
|
||
| describe "remove_member/2" do |
Contributor
There was a problem hiding this comment.
Suggested change
| describe "remove_member/2" do | |
| describe "remove_member/2 for team_user with user record" do |
Also needs a test for team_user with when there is no user record, which is when they are invited without having a prior account.
| end | ||
|
|
||
| describe "add_member/2" do | ||
| test "adds an existing user to a team", %{ |
Contributor
There was a problem hiding this comment.
also needs case where there is no existing user record and we only create the record on team_users table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and delete users from a team