Store totalCellCrossSection, centralize interpolation.#174
Merged
Conversation
* Grid.h: add free function interpolateNodalToCell * EedfCollision.*: use that, store the totalCellCrossSection and provide an accessor. * ElectronKinetics.cpp: use totalCellCrossSection(), do not repeat this task multiple times. See issue #169. Note that this does the non-controversial parts of #116.
Collaborator
Author
|
@JopHendrikx, also FYI. |
|
The author of this PR, janvdijk, is not an activated member of this organization on Codecov. |
added 2 commits
June 13, 2024 22:01
Test that grid.getNodes() is correctly interpolated up to grid.getCells(), up to essentially the machine accuracy.
Collaborator
Author
|
@daanboer, I think that can be merged now. I just marked this as 'ready for review'. |
added 3 commits
June 14, 2024 11:14
File Integrals.h has been renamed into GridOps.h. It now hosts various grid-related operations: interpolation, differentiation and integration. The inline interpolation function has been moved there from Grid.h. Tests have been added for the new cell->cell differentiation function cellDerivative, which has been extracted from ElectronKinetics (function calculateFirstAnisotropy). A test has been added (that u'=1).
daanboer
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this does the non-controversial parts of #116. After merging this branch into main (and then into the branch underlying #116), that will only contain the essential (yet controversial) parts: avoiding two-step interpolation.
Resolves issue #169