Fix button offset when window resizes#354
Merged
LmeSzinc merged 8 commits intoLmeSzinc:devfrom Mar 20, 2024
Merged
Conversation
LmeSzinc
reviewed
Mar 5, 2024
tasks/map/control/joystick.py
Outdated
Comment on lines
+37
to
+44
| TECHNIQUE_POINT_LOOSE_0 = build_technique_points_loose(TECHNIQUE_POINT_0) | ||
| TECHNIQUE_POINT_LOOSE_1 = build_technique_points_loose(TECHNIQUE_POINT_1) | ||
|
|
||
| TECHNIQUE_POINT_STRICT_1 = build_technique_points_strict(TECHNIQUE_POINT_1) | ||
| TECHNIQUE_POINT_STRICT_2 = build_technique_points_strict(TECHNIQUE_POINT_2) | ||
| TECHNIQUE_POINT_STRICT_3 = build_technique_points_strict(TECHNIQUE_POINT_3) | ||
| TECHNIQUE_POINT_STRICT_4 = build_technique_points_strict(TECHNIQUE_POINT_4) | ||
| TECHNIQUE_POINT_STRICT_5 = build_technique_points_strict(TECHNIQUE_POINT_5) |
Owner
There was a problem hiding this comment.
Add TECHINQUE_POINT_1.SEARCH.png to enlarge search area, dont dynamically build buttons
module/base/base.py
Outdated
| Args: | ||
| button(Button, tuple): Button instance or area tuple. | ||
| copy: | ||
| offset: |
LmeSzinc
added
bug / 缺陷
Contributor
Author
|
Ready to merge, also fixed technique_pt_5 figure. |
LmeSzinc
reviewed
Mar 12, 2024
Owner
LmeSzinc
left a comment
LmeSzinc
left a comment
There was a problem hiding this comment.
Remove unused assets, keep only TECHNIQUE_POINT_[012345], only TECHNIQUE_POINT_[01] have SEARCH attribute while the rest don't
module/base/base.py
Outdated
| color (tuple): RGB. | ||
| threshold: 255 means colors are the same, the lower the worse. | ||
| count (int): Pixels count. | ||
| offset: if the button is offset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#345 with button offset determined by whether the rhombus technique point 1 is filled or not.