Feature/cjc8/storekit #27
Conversation
| } | ||
|
|
||
| PlaygroundPage.current.liveView = vc | ||
| PlaygroundPage.current.needsIndefiniteExecution = true |
There was a problem hiding this comment.
For some reason I can't get the products to show up in the tableview, but I think that's because it's in a playground rather than a project. I'm having a hard time finding any help online (pretty niche situation) but i'll keep at it.
There was a problem hiding this comment.
Playgrounds do have that issue – have you logged/messed with the view to make sure it's getting displayed?
| } | ||
|
|
||
| open func productsRequest(_ request: SKProductsRequest, didReceive response: SKProductsResponse) { | ||
| print("received response") |
There was a problem hiding this comment.
For my own memory Remove print statement
| return { transaction in | ||
| switch transaction.transactionState { | ||
| case .failed: | ||
| SKPaymentQueue.default().finishTransaction(transaction) |
There was a problem hiding this comment.
I'm on the fence between finishing the transaction whenever the state is purchased or failed, or providing the function as a safe default in the constructor. I think I'm going to go with the latter, but your input would be nice
| import UIKit | ||
|
|
||
| public class LUXSubscriptionTableViewCell: UITableViewCell { | ||
| @IBOutlet weak var subscriptionNameLabel: UILabel! |
There was a problem hiding this comment.
Also, with generalizability in mind, I'm torn between making sure it displays the price or not enforcing it, since displaying the price is something that can be done in just a label or as a button (like we do in Tapper) and I'm having trouble finding a way to make sure they have something that shows the price but not restricting that to a certain UI element
There was a problem hiding this comment.
Let's assume they'll either use what we have or replace it wholesale – so basically, let's make all the assumptions we want about what's getting displayed, but put in a hook that someone could replace with custom functionality.
| } | ||
|
|
||
| public func productToPriceString(_ product: SKProduct) -> String { | ||
| let currency = product.priceLocale.currencySymbol ?? "" |
There was a problem hiding this comment.
WIP but will clean up in future commits
schrockblock
left a comment
schrockblock
left a comment
There was a problem hiding this comment.
Cool stuff, very excited for it
| } | ||
|
|
||
| PlaygroundPage.current.liveView = vc | ||
| PlaygroundPage.current.needsIndefiniteExecution = true |
There was a problem hiding this comment.
Playgrounds do have that issue – have you logged/messed with the view to make sure it's getting displayed?
|
|
||
| public var cancelBag: Set<AnyCancellable> = [] | ||
| @Published var products: [SKProduct] = [] | ||
| public var productsCall: CombineNetCall? |
There was a problem hiding this comment.
I'd love to find a way to not have to require a CombineNetCall here; is there a way we could instead either split this into a super and a subclass, one that just provides the functions and nothing else, and the other that has a smart default (using CombineNetCall perhaps)? Could we rely on a part of CombineNetCall, or Fireable, or just the returned data in some way? I'd love this to be flexible enough to use in the ReactiveSwift version of LUX, or generally no matter what the net stack looks like.
| import UIKit | ||
|
|
||
| public class LUXSubscriptionTableViewCell: UITableViewCell { | ||
| @IBOutlet weak var subscriptionNameLabel: UILabel! |
There was a problem hiding this comment.
Let's assume they'll either use what we have or replace it wholesale – so basically, let's make all the assumptions we want about what's getting displayed, but put in a hook that someone could replace with custom functionality.
| import LithoOperators | ||
| import PlaygroundVCHelpers | ||
|
|
||
| public func subscriptionViewController<C: LUXSubscriptionTableViewCell>(styleVC: @escaping (LUXSubscriptionViewController) -> Void, configureCell: @escaping (SKProduct, C) -> Void = configureSubscriptionCell, onTap: @escaping (SKProduct) -> Void = productToPayment >?> addPayment, termsPressed: (() -> Void)? = nil, delegate: LUXSubscriptionDelegate = LUXSubscriptionDelegate()) -> LUXSubscriptionViewController{ |
There was a problem hiding this comment.
You might make C just a regular UITableViewCell and just use ~> when you want to assume it's our cell
There was a problem hiding this comment.
Because it has two parameters, optionalCast won't work unless I embed it in the second method from LithoOperators, what I have as a default value is ~second(optionalCast) >>> ~configureSubscriptionCell, which compiles fine
|
Is this still in progress? |
|
@cjc8 ^^^? |
cjc8
force-pushed
the
feature/cjc8/storekit
branch
from
81cbca4 to
d18d930
Compare
No description provided.