-
Notifications
You must be signed in to change notification settings - Fork 6
Add on-ramps page #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on-ramps page #349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the text, grammar and links, but did not double-check if the details about each payment provider (supported tokens / countries) is correct, although Gemini says so.
Two general notes:
- This page is targeting builders/founders, right? The page is not consistently written in that regard as it sometimes rather sounds like we describe what on-/offramps end-users can use not which ones founders can integrate.
- Sometimes assets / geographic regions are mentioned for the providers, sometimes not. It could be nice to make this more consistent.
Co-authored-by: janhack <29209167+janhack@users.noreply.github.com>
janhack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some more comments.
Co-authored-by: janhack <29209167+janhack@users.noreply.github.com>
janhack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
What was the problem?
This PR resolves #LISK-2311