Switch from Template:LeagueIconSmall/mainpageTST to Template:LeagueIconSmall/custom#11
Merged
FO-nTTaX merged 4 commits intoLiquipedia:masterfrom Sep 9, 2025
Merged
Conversation
FO-nTTaX
reviewed
Sep 8, 2025
src/Hooks/MainHookHandler.php
Outdated
| $iconTemplatePrefix . '/custom', | ||
| NS_TEMPLATE | ||
| ); | ||
| if ( $iconfileTitle !== null && $iconfileTitle->exists() && $skin->getTitle() !== null ) { |
Member
There was a problem hiding this comment.
As long as the $iconfileTitle->exists() code is in there it will not see the commons version existing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template:LeagueIconSmall/customexists on commons and hence is available for all wikis, hence this removes the need for wikis to createTemplate:LeagueIconSmall/mainpageTSTif they want to switch from using LIS to using the icons from the LPDB data.Potential follow up: Adjust
Module:TournamentsSummaryTableto always (on all wikis) use the icon data from LPDB instead of LIS.