Conversation
There was a problem hiding this comment.
Pull request overview
Moves LakesideView skin CSS that affects wiki content styling into the shared stylesheets/commons SCSS modules (to be loaded via ResourceLoaderArticles), as prep for Lighthouse/skin changes.
Changes:
- Added a large set of new SCSS modules for Special pages, page-specific styles (Search/EditConflict), components (tables/forms/editor/etc.), and extensions (OOUI, FlaggedRevs, jQuery UI, misc).
- Updated existing shared styling for tabs (
Tabs.scss) and navboxes (Navbox.scss). - Tweaked some misc styling (e.g., Liquipedia-links badge tooltip + some browser-specific rules) in
Miscellaneous.scss.
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| stylesheets/commons/Tabs.scss | Updates tab spacing/positioning and refines .nav-tabs styling. |
| stylesheets/commons/Specials.scss | Adds styling overrides for various MediaWiki special pages. |
| stylesheets/commons/Pages/Search.scss | Adds search page UI styling (tabs, options, thumbnails). |
| stylesheets/commons/Pages/EditConflict.scss | Adds styling for edit conflict/twocolconflict UI. |
| stylesheets/commons/Navbox.scss | Adds theme-aware navbox background/title/list styling. |
| stylesheets/commons/Miscellaneous.scss | Small adjustments for badge tooltip and browser-specific rules. |
| stylesheets/commons/Extensions/OouiSelect.scss | Styles OOUI select/dropdown/menu + RC filters select2 pieces. |
| stylesheets/commons/Extensions/OouiPopup.scss | Styles OOUI popup widgets + anchors/icons. |
| stylesheets/commons/Extensions/OouiMultiSelectWidget.scss | Styles OOUI multiselect/tag widgets. |
| stylesheets/commons/Extensions/OouiModal.scss | Styles OOUI modal/process dialog overlay/frame/buttons. |
| stylesheets/commons/Extensions/OouiInputFields.scss | Styles OOUI text inputs (hover/focus/disabled/placeholder). |
| stylesheets/commons/Extensions/OouiCheckboxes.scss | Styles OOUI checkbox visuals and focus/checked states. |
| stylesheets/commons/Extensions/OouiButtons.scss | Styles OOUI button variants (primary/default/frameless/etc.). |
| stylesheets/commons/Extensions/Ooui.scss | Misc OOUI layout fixes (padding, tabs, labels, toggle switch). |
| stylesheets/commons/Extensions/Jquery.scss | Styles jQuery UI dialog/form elements and sorting icons. |
| stylesheets/commons/Extensions/Flaggedrevs.scss | Styles FlaggedRevs review/pending/unreviewed markers and UI. |
| stylesheets/commons/Extensions/ExtensionsMisc.scss | Misc extension styling (message boxes, interwiki, ads, patrol, scribunto). |
| stylesheets/commons/Components/Tables.scss | Adds general table/wikitable/bootstrap table overrides and MW 1.43 table fix. |
| stylesheets/commons/Components/SearchSuggestions.scss | Styles search suggestion dropdown results/hover states. |
| stylesheets/commons/Components/Popup.scss | Styles popovers (border/theme header/body colors). |
| stylesheets/commons/Components/MobileSearch.scss | Styles fixed mobile search bar layout. |
| stylesheets/commons/Components/Jexel.scss | Styles jexcel tables/pagination and adds masked OOUI icons. |
| stylesheets/commons/Components/Images.scss | Image sizing restrictions + thumbnail styling and responsive float changes. |
| stylesheets/commons/Components/Headings.scss | Adds heading/hr styling consistent with theme colors. |
| stylesheets/commons/Components/Gallery.scss | Adds packed/overlay/hover gallery behavior and thumb styling. |
| stylesheets/commons/Components/Forms.scss | Adds bootstrap-like form controls/button styling for content column. |
| stylesheets/commons/Components/Editor.scss | Styles edit form + WikiEditor toolbar/menus/icons. |
| stylesheets/commons/Components/Documentation.scss | Styles .documentation box for light/dark themes. |
| stylesheets/commons/Components/DiffView.scss | Styles diff added/removed/context coloring for diff pages. |
| stylesheets/commons/Components/DatePicker.scss | Styles MediaWiki date/calendar widgets. |
| stylesheets/commons/Components/ComponentsMisc.scss | Misc moved component styles (catlinks, debug, contribute, code blocks, etc.). |
| stylesheets/commons/Components/Buttons.scss | Adds shared button styling + ghost/secondary/themed/destructive variants. |
| stylesheets/commons/Components/BreadCrumbs.scss | Hides subpages in certain namespaces + breadcrumb background tweaks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
new files should be added to |
FO-nTTaX
left a comment
FO-nTTaX
left a comment
There was a problem hiding this comment.
Feels like there's a lot of styles in here that are MW specific, not required for content of normal pages
Thanks, I think I deleted all irrelevant files. I did keep for example |
Yeah those are fine, just all the special page stuff felt unnecessary |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nto feature/move-lakesideview-css # Conflicts: # stylesheets/Main.scss
Summary
As preparation for Lighthouse we need to move a css from the lakesideview skin to LuaModules, because this css controls the styling for the wikicontent.
I've tried to put some of the css in a relevant existing css file but most is just copy paste.
Please review this on the test wiki. I've looked through a few pages but it could use a few extra pair of eyes.
How did you test this change?
https://laura.wiki.tldev.eu/rocketleague/Main_Page
Notes
I need to make an MR for lakesideview to remove all the css as well, so don't merge it just yet 😆