feat(match2): grid-based layout for match summaries#7285
Open
ElectricalBoy wants to merge 29 commits intomainfrom
Open
feat(match2): grid-based layout for match summaries#7285ElectricalBoy wants to merge 29 commits intomainfrom
ElectricalBoy wants to merge 29 commits intomainfrom
Conversation
ElectricalBoy
added
g: valorant
hjpalpha
reviewed
Mar 22, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
what perf implications does this have?
- memory
- runtime
- include size
Collaborator
|
seems suboptimal on tablet: |
Collaborator
|
page for testing it on sc2: https://liquipedia.net/starcraft2/User:Hjpalpha/wip31 |
Collaborator
Author
this pr involves new css classes |
Collaborator
Author
negligible Lua memory/runtime difference |
hjpalpha
approved these changes
Mar 23, 2026
Collaborator
|
Planning on doing the rest of the wikis too? Or leaving that for a future PR? |
Rathoz
reviewed
Mar 24, 2026
Rathoz
reviewed
Mar 24, 2026
Collaborator
Author
lets start small then expand to the rest |
ElectricalBoy
force-pushed
the
matchsummary-grid-based-layout
branch
from
10d1219 to
1ace2b0
Compare
hjpalpha
approved these changes
Mar 25, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
seems reasonable on mobile
Rathoz
reviewed
Mar 25, 2026
Rathoz
reviewed
Mar 25, 2026
ElectricalBoy
force-pushed
the
matchsummary-grid-based-layout
branch
from
1ace2b0 to
fd6e0e4
Compare
Rathoz
reviewed
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds grid-based layout for match summaries.
How did you test this change?
(+ browser dev tools, of course)