fix: temporary workaround to fix the issues in php-scss 1.x#6463
Merged
fix: temporary workaround to fix the issues in php-scss 1.x#6463
Conversation
Collaborator
|
what's the ETA on v2.0 migration? |
Collaborator
Author
At least a week, probably more, bunch of dependency and testing needed |
mbergen
approved these changes
Aug 28, 2025
Collaborator
mbergen
left a comment
mbergen
left a comment
There was a problem hiding this comment.
I have no idea about SCSS, so do whatever is necessary.
I guess technically we could also revert this file alone to less for now.
Collaborator
Author
We could, but I would rather move forward and have no less. It's fully functional, as this, just a little uglier |
Eetwalt
pushed a commit
that referenced
this pull request
Sep 1, 2025
* fix: temporary workaround to fix the issues in php-scss 1.x * add comment
Rathoz
added a commit
that referenced
this pull request
Sep 3, 2025
* initial testing * completed state * render MatchHeaderBR in match card * style changes * corrected icon * use trophy instead of icon * get gamedata for match This is not a permanent solution, needs refactoring later. * added github cli instructions in the docs * added gameData to matchcard * corrected type, added conditionals * corrected string replacement * corrected link structure * url constructing and logs * url constructing and conditional for showing map * simplified map link * completed conditional and match state rendering * trophy rendering * moving icon colour classes * better stage name * simplifying * formatting * improvements * unused import * remove unnecessary field Co-authored-by: Rikard Blixt <rikardblixt@gmail.com> * style tweaks * un-flip opponent display * adjusted map display logic * refactor to placement rendering and fix typo * Update lua/wikis/commons/Widget/Match/TournamentBar.lua Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> * fixed mapDisplayName * use sub instead of filter so theres always only three values returned * Update lua/wikis/commons/MatchTicker/DisplayComponents/New.lua Co-authored-by: SyntacticSalt <mail@mbergen.de> * improvements * fix opponents * moved and renamed header to subdirectory * chore: Add latest AoE4 and AoM civilizations and gods (#6438) * Update Data.lua Added Dynasties of the East civs to Data.lua. * Added Dynasties of the East civs to IconData.lua. * Fixed alphabetic order in aoe Factions/Data.lua. * Added Dynasties of the East civ aliases to Data.lua. * Added AoM Heavenly spear gods to AoE Faction/Data.lua. * Added AoM Heavenly spear gods to AoE Faction/IconData.lua. --------- Co-authored-by: Rikard Blixt <rikardblixt@gmail.com> * docs(match2): fix incorrect capitalization in MatchPageDisplay (#6449) fix capitalization * fix: Remove colors in CR matchsummary (#6448) * fix(match2): game win/loss indicator not shown in hearthstone match summary with incomplete input (#6458) * spelling * fix children processing * type annotation * type annotation * docs(opponent): fix spelling in documentation (#6457) spelling * chore: convert less to scss (#6433) * chore: convert less to scss * undo some stuff we can leave for a later pr to make it easier to review * typo * migrate visual testing to scss * scss fixes * chore: update visual snapshots * cleanup * fixes? * chore: update visual snapshots * cleanup * remove less, update docs and pipeline * fix unary op being treated as binarry op (https://sass-lang.com/documentation/breaking-changes/strict-unary/) --------- Co-authored-by: Rathoz <3426850+Rathoz@users.noreply.github.com> * fix: dota2 hero panel styling (#6462) * fix: temporary workaround to fix the issues in php-scss 1.x (#6463) * fix: temporary workaround to fix the issues in php-scss 1.x * add comment * docs: fix incorrect spelling for player table (#6469) typo * test: remove TeamTemplate fake (#6472) * kick mock TeamTemplate module * add missing data to mock * add alias to mock * load tt mock inside standings test * teardown afterwards * add heroic data to mock * add BDS to mock * add all minimally required tts * one last tt * add complete tt9 data * fix expected opponentname * fix: missing nil catch in opponent module (#6470) * fix: Correctly display single-transfer lists (#6467) * fix: Correctly display single-transfer lists * offset limit * refactor(infobox): use daterange widget in upcoming and ongoing tournaments widget (#6461) * enable type anno properly * type annotation * use DateRange widget * remove unused import * read correct field * refactor: replace style attribute with css in project overview (#6453) replace style attribute with css * chore: Add youtube param to AoE CopyPaste (#6465) * refactor: clean up match schedule display implementation (#6456) * header to widget * main wrapper to widget * row to widget * buildOpponent to widget * use anyOf for page query * use ge / le for date query * adjust return type * score to widget * dateDisplay to widget * type anno * restore hiddensort * matchPageLinkDisplay to widget * clean up html widget calls * flip condition * syntax * slap loadData to Module:Info import * further condense condition building Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com> --------- Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com> * eof * removed eof * collect children and simplify mapIsSet usage Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> * syntax Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> * import Array * reorder imports --------- Co-authored-by: Rikard Blixt <rikardblixt@gmail.com> Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> Co-authored-by: SyntacticSalt <mail@mbergen.de> Co-authored-by: Libavi <165576651+Libavi@users.noreply.github.com> Co-authored-by: Rathoz <3426850+Rathoz@users.noreply.github.com> Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
Collaborator
|
now that Liquipedia/ResourceLoaderArticles#15 is merged we should look into reverting this |
Member
|
Don't for now, we're reverting the scssphp upgrade |
Member
We could look into cleaning this up now too, we redeployed scssphp:2 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do some temp workarounds
How did you test this change?
Live