Skip to content

feat: Support alt-click for widget invokes #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FO-nTTaX merged 3 commits into from
Aug 19, 2025
Merged

feat: Support alt-click for widget invokes #19

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc7ccbe
feat: Support alt-click for widget invokes
mbergen Aug 15, 2025
1d4e77f
add semicolon
mbergen Aug 15, 2025
c817a66
Remove a bunch of unneeded code
FO-nTTaX Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 4 additions & 37 deletions resources/scripts/codemirror.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,3 @@
if ( !String.prototype.startsWith ) {
String.prototype.startsWith = function( searchString, position ) {
position = position || 0;
return this.slice( position, position + searchString.length ) === searchString;
};
}

if ( !String.prototype.endsWith ) {
String.prototype.endsWith = function( searchString, position ) {
const subjectString = this.toString();
if ( typeof position !== 'number' || !isFinite( position ) || Math.floor( position ) !== position || position > subjectString.length ) {
position = subjectString.length;
}
position -= searchString.length;
const lastIndex = subjectString.indexOf( searchString, position );
return lastIndex !== -1 && lastIndex === position;
};
}

if ( !String.prototype.includes ) {
String.prototype.includes = function( search, start ) {
'use strict';
if ( typeof start !== 'number' ) {
start = 0;
}
if ( start + search.length > this.length ) {
return false;
} else {
return this.indexOf( search, start ) !== -1;
}
};
}

/*
* Adapted from https://www.mediawiki.org/wiki/Extension:CodeMirror
* License: GPL 2.0 or later
Expand Down Expand Up @@ -328,10 +295,6 @@ if ( !String.prototype.includes ) {
lineWrapping: linewrapping,
styleActiveLine: true
} );
// Our best friend, IE, needs some special css
if ( window.navigator.userAgent.indexOf( 'Trident/' ) > -1 ) {
$( '.CodeMirror' ).addClass( 'CodeMirrorIE' );
}
if ( linewrapping ) {
$( '.CodeMirror' ).addClass( 'lineWrapping' );
}
Expand Down Expand Up @@ -380,6 +343,10 @@ if ( !String.prototype.includes ) {

if ( pagename.startsWith( 'module=' ) ) {
pagename = pagename.slice( 7 );
} else if ( pagename.startsWith( 'widget=' ) ) {
// Support invokes of style
// {{#invoke:Lua|invoke|module=Widget/Factory|fn=fromTemplate|widget=pagename}}
pagename = pagename.replace( 'widget=', 'Widget/' );
} else if ( !parserfunction.hasClass( 'cm-mw-parserfunction-name' ) ||
parserfunction.text() !== '#invoke' ) {
return;
Expand Down