Open
Conversation
* Play a bit around with text boxes
flodiebold
reviewed
Jan 30, 2019
| .ok_or(CommandTaskReplaceValuesError)?; | ||
| let match_string = format!("\\{{\\{{{}\\}}\\}}", task_variable.name); | ||
| let re = RegexBuilder::new(&match_string).build()?; | ||
| output = re.replace_all(&output, value.as_str()).to_string(); |
Collaborator
There was a problem hiding this comment.
du kannst als replacer eine FnMut(&Captures) -> String angeben, d.h. du könntest alle variablen auf einmal abhandeln (und die gleiche regex wie weiter oben verwenden)
Owner
Author
There was a problem hiding this comment.
Well, in that case how would I return the error from the closure?
E.g.
pub fn to_executable_string(<···>) -> Result<String, Box<std::error::Error>> {
let template_regex = Regex::new(r"\{\{(.+?)\}\}").unwrap();
output = template_regex
.replace_all(&output, |caps: &Captures| {
variables.get(&caps[0]).ok_or(CommandTaskReplaceValuesError)? // <- Error
})
.to_string();
// <···>Does not compile because the error now gets returned inside the closure/.
Collaborator
There was a problem hiding this comment.
Yeah, you can't... you could first check that all the variables have values, and then do the actual replacing, though
Collaborator
There was a problem hiding this comment.
is it actually possible that variables are missing from the hash map though?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
command.cmdJSON string as aCommandTaskwithCommandTaskVariablesinstead of a simpleString