Skip to content

Conversation

@cjumel
Copy link
Contributor

@cjumel cjumel commented Sep 16, 2025

Description

This PR refactors the tests to leverage the pytest.mark.parameterize syntax and removes most of the duplicate in the test files. This made me able to test a bit more (some more usecases, and more tests, like the check of the data sent to the request) while also reducing the number of test lines by half.

Doing so I realized a lack of systematization in the way we handle default parameters: sometimes they were not sent to the API at all, sometimes with the SDK default value. If SDK & API defaults are the same, this doesn't change a thing, but otherwise it might create surprises, so I made sure the default SDK parameters are always passed.

Checklist

  • I have installed pre-commit on this project (for instance with the make install-dev command)
    before creating any commit, or I have run successfully the make lint command on my changes
  • I have run successfully the make test command on my changes
  • I have updated the README.md if my changes affected it

@cjumel cjumel marked this pull request as ready for review September 16, 2025 15:10
@cjumel cjumel requested a review from glm3 September 16, 2025 15:10
Copy link
Contributor

@glm3 glm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjumel cjumel merged commit 2d58d85 into main Sep 17, 2025
2 checks passed
@cjumel cjumel deleted the cj/tests branch September 17, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants