Update #9
Closed
Update #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aalivexy
requested changes
Oct 5, 2025
Collaborator
Aalivexy
left a comment
Aalivexy
left a comment
There was a problem hiding this comment.
如果你要PR的话请一个功能发一个PR，并且保证编译通过
Collaborator
|
outlook给我邮件全干垃圾箱了，啧 |
This reverts commit a3be385.
Aalivexy
reviewed
Oct 9, 2025
| text: String, | ||
| from: String, | ||
| to: String, | ||
| result: String, |
Collaborator
There was a problem hiding this comment.
建议你先review一下代码，不要vibe完能跑就行，加这玩意真是不明所以
如果你希望有个啥新功能可以开个issue说一下为什么想要，我来做就行，这些commit真是污染git历史......
Member
Author
There was a problem hiding this comment.
这些改动是为了兼容 mtranserver 的接口，commit message 里写了。
并非 “不要 vibe 完能跑就行，加这玩意真是不明所以”
| const ENV_API_KEY: &str = "API_KEY"; | ||
| const ENV_LOG_LEVEL: &str = "RUST_LOG"; | ||
|
|
||
| // Environment variable aliases |
| Ok(models) | ||
| } | ||
|
|
||
| async fn shutdown_signal() { |
| let server_ip = std::env::var(ENV_SERVER_IP).unwrap_or_else(|_| "127.0.0.1".to_string()); | ||
| let server_port = std::env::var(ENV_SERVER_PORT) | ||
| .ok() | ||
| let server_port = get_env_with_alias(ENV_SERVER_PORT, ENV_SERVER_PORT_ALIAS) |
| let from_code = get_iso_code(&source_lang)?; | ||
| let to_code = get_iso_code(&target_lang)?; | ||
|
|
||
| // If source and target languages are the same, return the original text |
Collaborator
There was a problem hiding this comment.
这测试我觉得是真没什么用，要说覆盖率它基本没啥覆盖，要说跑通它也没有全流程跑通
Collaborator
|
你要不然和我说你想要啥吧，这PR没法合并，不然commit历史会一团糟 |
Member
Author
|
兼容 mtranserver 的接口和环境变量，还有一些都写在注释里了。不想要的你可以直接编辑 PR |
Member
Author
|
如果你有更好的兼容方式，可以加上，环境变量用别名的方式确实不太优雅。 |
Collaborator
问题是我没看懂要兼容谁
这俩本来也不能直接替换，模型不一样啊，linguaspark默认是不捆绑模型的，如果你希望容器级别的默认模型+兼容，那应该改的是dockerfile/compose文件，而不是代码 |
Member
Author
|
行 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Aalivexy