Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements an A/B experiment for the main horoscope button using LaunchDarkly feature flags, while also refactoring the button styling system to use an outlined design by default with enhanced dark mode support.
Changes:
- Integrated LaunchDarkly SDK with experiment logic to conditionally apply a
main-ctaclass to the horoscope button - Refactored default button styles from gradient-filled to outlined (transparent background with colored border)
- Added distinct styling for the experimental main CTA button variant with gradients and shadows, including dark mode variations
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| templates/index.html | Added LaunchDarkly SDK and experiment script imports |
| static/js/ld-experiment.js | Implements experiment logic to toggle main-cta class based on feature flag |
| static/css/style.css | Refactored button styles to outlined design and added main CTA experiment variant styles |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
LaunchDarkly flag references🔍 1 flag added or modified
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an A/B experiment for the main call-to-action (CTA) button using LaunchDarkly, along with significant visual updates to button styles for both light and dark modes. The changes focus on enabling experiment-driven styling for the main CTA button, refactoring general button styles to use an outlined look by default, and ensuring dark mode compatibility.
Experiment integration and feature flagging:
ld-experiment.jsscript that initializes the LaunchDarkly SDK, checks theget-horoscope-main-button-experimentflag, and dynamically toggles themain-ctaclass on the main horoscope button based on the experiment variant.index.htmlto load the LaunchDarkly JS SDK and the new experiment script.Button style refactoring:
style.cssto use an outlined appearance (transparent background, colored border, and text), with hover and active states providing subtle color changes. Box shadows and gradients were removed from standard buttons for a cleaner look. [1] [2] [3] [4] [5]Main CTA and dark mode styling:
.button-group button.main-ctato provide a prominent gradient background, larger font, and stronger box shadow, including hover/active states and dark mode variants.