Virtio msg: Add unique identifier and relax error handing by the bus #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the header to be 8 bytes and include a unique identifier that can be use to correlate request to responses. Rename the msg_id field to msg_op as having a msg_id and msg_uid field and using identifiers in 2 contexts would have been unclear. Rework ID to OP and change wording message identifer to message operation to be coherent in the rest of the specification. Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
Add a sub-section to do a first explanation draft of how the message correlation is to be done using a combination of a message device number and the message unique identifier value. Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
Relax error handling in the virtio-msg bus and introduce wording to allow the virtio-msg bus to report error to the virtio-msg transport if a request could not be transmited or a malformed response was received. This prevents the need to generate dummy responses in the bus and make the specification coherent with the current Linux PoC implementation. Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
Collaborator
|
The commits from this PR were included in PR #25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Those 3 patches are a proposal to handle the following things that have been discussed:
This is a draft for discussion