Changes as discussed June 5 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertrand-marquis
approved these changes
Jun 16, 2025
Collaborator
bertrand-marquis
left a comment
bertrand-marquis
left a comment
There was a problem hiding this comment.
Definitely looks good to me.
Just one minor comment
arnopo
reviewed
Jun 16, 2025
arnopo
approved these changes
Jun 19, 2025
As decided on June 5th, the EVENT_CONFIG_EMPTY message is deleted. Instead of documenting "invalid" settings of device status and configuration generation count, I have removed that use case of EVENT_CONFIG. EVENT_CONFIG can still be used with an without changed configuration data in the payload. More explicit documentation on these two cases has been added. Signed-off-by: Bill Mills <bill.mills@linaro.org>
The hex value for this case was always intended to be "all 1s" but was mis-specified before. This fixes that. This also makes it clear that for the EVENT_AVAIL use case, this would typically be used on the device side. (The driver side always knows which virtqueue was updated as it originates this event.) Signed-off-by: Bill Mills <bill.mills@linaro.org>
* writeing -> writing * support to send -> support sending * /msgref -> \msgref Signed-off-by: Bill Mills <bill.mills@linaro.org>
This uses the EVENT_ name for event messages and replaces two messages with one that includes a state value. This allows future expansion of state to handle things like suspend/resume and request removal. Signed-off-by: Bill Mills <bill.mills@linaro.org>
Fix the copy and past error here. Signed-off-by: Bill Mills <bill.mills@linaro.org>
* Add support for device owned shared memory segments from virtio v1.3 * Add support for Admin virtqueues from virtio v1.4 (draft) Signed-off-by: Bill Mills <bill.mills@linaro.org>
Make the order of fields: * [config gen count, if present] * config offset * config length * config data Signed-off-by: Bill Mills <bill.mills@linaro.org>
* Use full state names in description * Use 1 & 2 as state values Signed-off-by: Bill Mills <bill.mills@linaro.org>
* Use "\emph{MAY} be zero" for config data length
Signed-off-by: Bill Mills <bill.mills@linaro.org>
This is hard to describe and real implementations may just use a loop anyway. So delete this for now anyway. A loop is required in the bus when: * One OoB notification can trigger multiple virtio devices * One OoB notification can trigger SOME virtqueues but not all So this value only covers one use case and it may cause more confusion than value. Signed-off-by: Bill Mills <bill.mills@linaro.org>
Document what we have done since RFC1. Signed-off-by: Bill Mills <bill.mills@linaro.org>
* As discussed Jun 19, mention work on FF-A spec is underway but don't promise a date. * Do likewise for the AMP data structures and first bus message set * Do likewise for aligned implementations and PATCH v1 Signed-off-by: Bill Mills <bill.mills@linaro.org>
wmamills
force-pushed
the
wam-review-06-09
branch
from
7ded8c2 to
5874b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PDF: https://github.com/wmamills/virtio-msg-spec/releases/download/wam-review-06-09-wmamills-draft-v16/wam-review-06-09-wmamills-draft-v16.pdf
V1:
V2:
V3: