fix: auto-force file keyring when GOG_KEYRING_PASSWORD is set#1
Merged
Sheldenshi merged 2 commits intomainfrom Mar 20, 2026
Merged
fix: auto-force file keyring when GOG_KEYRING_PASSWORD is set#1Sheldenshi merged 2 commits intomainfrom
Sheldenshi merged 2 commits intomainfrom
Conversation
When the backend is "auto" and GOG_KEYRING_PASSWORD is set, force the file backend instead of trying Keychain/SecretService first. If someone provides a keyring password, they clearly intend file-based storage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ends The previous test only checked that OpenDefault() returned non-nil, which would pass even if Keychain was used. Replace with a spy on keyringOpenFunc that captures the Config and asserts AllowedBackends contains only FileBackend. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GOG_KEYRING_BACKENDisauto(default) andGOG_KEYRING_PASSWORDis set, automatically force the file backend instead of letting the keyring library pick macOS KeychainkeyringOpenFuncand assertAllowedBackendsis[FileBackend]Test plan
go test ./internal/secrets/...— all 33 tests passshouldForceFileForPassword(auto+password, auto+empty, auto+unset, explicit file, explicit keychain)keyring.OpenhasAllowedBackends: [FileBackend]🤖 Generated with Claude Code