Conversation
codynhat
left a comment
codynhat
left a comment
There was a problem hiding this comment.
Here are two test cases for LigoSafeEscrow
should deposit to predicted address- Call
predict - Make native ETH deposit at address
- Deploy safe at address
- Check that balance is equal to original deposit
- Call
should issue refund to paymentReceiver- Call
predictwith paymentReceiver - Make native ETH deposit at address
- Deploy safe at address
- Check that paymentReceiver received a refund
- Call
packages/safe-escrow/src/safe.ts
Outdated
| }); | ||
| } | ||
|
|
||
| private async _wyrePayment( |
There was a problem hiding this comment.
I believe the Wyre call will require some KYC? Like the person's name and address below.
I'm not sure that this is the best place to integrate with Wyre. What are the different ways to integrate? Do they have their own UI? A whitelabeling option? Does using the API here mean we can have our own UI?
There was a problem hiding this comment.
As we talked about synchronously, let's just remove Wyre for now.
packages/safe-escrow/src/safe.ts
Outdated
| } | ||
|
|
||
| // setup relayer | ||
| async setupRelayer() { |
There was a problem hiding this comment.
Is this just a temporary solution for setting up a relayer?
We may want this to live in the agent. An agent can have their own Infura account and "gas tank".
I also see this in the Infura docs:
Infura Transactions (ITX) is currently undergoing changes and is only supported for existing customers.
Does this mean we can't use ITX as a new customer?
There was a problem hiding this comment.
As we talked about synchronously, let's just remove ITX for now.
| if (!this.#safeFactory) { | ||
| throw new Error("LigoSafeEscrow is not connected"); | ||
| } | ||
| const safeAccountConfig: SafeAccountConfig = { |
There was a problem hiding this comment.
Both SafeAccountConfig and SafeDeploymentConfig will later need to be given to an agent to do the deployment. These probably could be returned from this function.
2 participants
No description provided.