Fix setup-dev.ps1 failing on Windows PowerShell 5.1#51
Open
Wyatt Bartel (wybartel) wants to merge 1 commit intoLightricks:mainfrom
Open
Fix setup-dev.ps1 failing on Windows PowerShell 5.1#51Wyatt Bartel (wybartel) wants to merge 1 commit intoLightricks:mainfrom
Wyatt Bartel (wybartel) wants to merge 1 commit intoLightricks:mainfrom
Conversation
…rs (box-drawing, checkmarks, em-dash) caused a parser error when PowerShell 5.1 read the UTF-8 file without BOM using the system ANSI code page. Replace all non-ASCII decorative characters with ASCII equivalents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows PowerShell 5.1 reads UTF-8 files without a BOM using the system ANSI code page (CP1252). Several Unicode characters in the script (em-dashes, box-drawing chars, checkmarks) contain bytes that are interpreted as string delimiters in CP1252, causing a parser error. This PR replaces all non-ASCII characters with ASCII equivalents for ease of compatibility long term