Skip to content

Method/plot odf section#10

Open
Gbowker wants to merge 10 commits intodevfrom
method/plot_odf_section
Open

Method/plot odf section#10
Gbowker wants to merge 10 commits intodevfrom
method/plot_odf_section

Conversation

@Gbowker
Copy link
Contributor

@Gbowker Gbowker commented May 17, 2022

This pull request is to allow the user the ability to plot odf sections in place of pole figures with the visualise_volume_element_response task using the method texture_odf_section.

For the time being, I just need to ensure this works, so have replicated any code for plotting pole figures and changing pole_figure to odf_section where applicable.

  • Ideally the user may define the euler angle (phi1, PHI, phi2) and value in degrees for this task, but to start with mtex should plot the phi2 45 degree section by default.
  • Next, the user should also be able to define whether they would like points on the plot for each orientation or contours representing the ODF. Initially, both options have been set to produce the contured ODF section.

Please comment here for any further suggestions on improvements. Thanks, Guy

@Gbowker Gbowker requested a review from aplowman May 17, 2022 15:43
@Gbowker Gbowker self-assigned this May 17, 2022
@Gbowker Gbowker added enhancement New feature or request help wanted Extra attention is needed labels May 17, 2022
@aplowman
Copy link
Contributor

I think you are missing a CLI_format_mapper decorator around multiple_miller_indices_formatter here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments