Open
Conversation
adnan-lb
approved these changes
Jan 14, 2025
rahman-lb
requested changes
Jan 14, 2025
| acl=['ALLOW_NONE'], | ||
| ip_acl=vol_ipAcl | ||
| ip_acl=vol_ipAcl, | ||
| qos_policy=qos_policy) |
There was a problem hiding this comment.
I think you have one extra closing parenthesis )
cinder/volume/drivers/lightos.py
Outdated
| compression = self._parse_extra_spec(type_compression, | ||
| default_compression) | ||
| num_replicas = str(specs.get('lightos:num_replicas', num_replicas)) | ||
| qos_policy = str(specs.get('lightos:qos_policy', None)) |
There was a problem hiding this comment.
@yuval-lb
If you don't provide "lightos:qos_policy" to volume Type, this call will convert the default None to a string-value, this string "None" will pass your check at line #254 assuming you have a policy with name "None" on Lighybits storage and volume creation will fail.
if kwargs.get("qos_policy", None) is not None:
yuval-lb
force-pushed
the
yuval/add_qos_support
branch
2 times, most recently
from
8b3121b to
ea45d56
Compare
rahman-lb
approved these changes
Jan 20, 2025
|
@yuval-lb do you want to merge to master! |
yuval-lb
force-pushed
the
yuval/add_qos_support
branch
from
ea45d56 to
2de2abb
Compare
Collaborator
Author
I am not merging its just for your review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBD: update README files