-
Notifications
You must be signed in to change notification settings - Fork 0
Email templating engine #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/email-service-async
Are you sure you want to change the base?
Conversation
Build/bump python to 3.13.8
| error_message=f"Sending new user email to user {user.id} failed", | ||
| from app.users.schemas.templates import NewUserTemplate | ||
|
|
||
| template = NewUserTemplate(name=user.email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the template not being inyectable here. Is there a specific reason?
I'm thinking about maybe A/B testing where you want to send 2 different new user emails to users depending on X factor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally agree with you.
I want to add that functionality on a later refactor, to clean up the email service so that it is closed for modification (which it currently is not, as it basically requires a new method for each email type).
I didn't do it here because I didn't want to scope creep this PR. Would you be ok with working on that on a different PR?
Create templates submodule
Features
BaseTemplateandBaseEmailTemplatepydantic schemas to relate template files and required argumentsProof of testing
Sample email
Test suite