feat: implement /api/update/readiness endpoint + structured update ch…#352
Open
eva57gr wants to merge 2 commits intoLight-Heart-Labs:mainfrom
Open
feat: implement /api/update/readiness endpoint + structured update ch…#352eva57gr wants to merge 2 commits intoLight-Heart-Labs:mainfrom
eva57gr wants to merge 2 commits intoLight-Heart-Labs:mainfrom
Conversation
Lightheartdevs
requested changes
Mar 18, 2026
Collaborator
Lightheartdevs
left a comment
There was a problem hiding this comment.
Review: REQUEST CHANGES
Blocking: Bare except Exception in _check_compatibility_status()
CLAUDE.md: "Never except Exception: return." This catches everything and returns a dict instead of crashing. Narrow to except OSError (the only realistic failure mode beyond the already-caught TimeoutExpired), or remove.
Blocking: Synchronous subprocess.run in async endpoint
Blocks the event loop for up to 30s. Every other subprocess call in this file uses asyncio.create_subprocess_exec. Use that or asyncio.to_thread().
Blocking: Duplicated script resolution
New _resolve_update_script_for_readiness() has a different candidate list than trigger_update(). Readiness could report "available" while POST /api/update returns 501. Unify into one shared function.
Non-blocking:
- Dead
model_dump/isinstancecoercion block —get_version()always returns dict, remove the duck-typing datetime.now(timezone.utc).isoformat() + "Z"repeated 6+ times — extract helper- Tests are well-structured, good coverage
🤖 Reviewed with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ecks