feat: enforce extension manifest + shared registry runtime parity#321
Open
eva57gr wants to merge 5 commits intoLight-Heart-Labs:mainfrom
Open
feat: enforce extension manifest + shared registry runtime parity#321eva57gr wants to merge 5 commits intoLight-Heart-Labs:mainfrom
eva57gr wants to merge 5 commits intoLight-Heart-Labs:mainfrom
Conversation
Lightheartdevs
requested changes
Mar 17, 2026
Collaborator
Lightheartdevs
left a comment
There was a problem hiding this comment.
additionalProperties: false on the manifest schema will break all existing extension manifests that have undeclared fields. Either bump the schema version so old manifests aren't suddenly invalid, or add a migration script. The importlib-based service-registry sharing also adds fragile path inference at import time.
Collaborator
|
The schema tightening is good work, but
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.