[COMMPORTAL-1424][JW] add crop option to ImageUpload #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qroll
reviewed
Dec 17, 2025
Sharptail
force-pushed
the
feat/COMMPORTAL-1424
branch
from
68ded02 to
6002375
Compare
Sharptail
force-pushed
the
feat/COMMPORTAL-1424
branch
from
6002375 to
e4c5da2
Compare
qroll
approved these changes
Dec 17, 2025
qroll
requested changes
Dec 17, 2025
Contributor
qroll
left a comment
qroll
left a comment
There was a problem hiding this comment.
sorry, missed this out; could you include a unit test to verify that resample is called with the right arguments when crop is enabled/disabled?
qroll
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
added a crop option to ImageUpload component
also fixed ImageUpload warning box not rendering html tags as the string was not sanitized
delete branch
Changelog entry