CCUBE-2031: Enhance DS to support an image and component within the popover #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qroll
requested changes
Dec 11, 2025
Contributor
qroll
left a comment
qroll
left a comment
There was a problem hiding this comment.
also include a unit test for the the schema object option
qroll
reviewed
Dec 11, 2025
qroll
requested changes
Dec 16, 2025
qroll
requested changes
Dec 29, 2025
| expect(screen.getByText("Schema hint content")).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it("should handle enhanced content types without error", () => { |
Contributor
There was a problem hiding this comment.
sorry, what does enhanced content type mean here? this test looks to be somewhat similar to the one above ("should render FEE schema content in hint") so we could stick to the previous one?
| hint: { | ||
| content: { | ||
| text: { uiType: "text-body", children: "Schema hint content" }, | ||
| } as any, |
|
|
||
| export const PopoverComponent = Template("popover-component").bind({}); | ||
| PopoverComponent.args = { | ||
| export const TooltipCustomisationWithSchema = Template("popover-component").bind({}); |
Contributor
There was a problem hiding this comment.
nit: move below the TooltipCustomisation story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Additional information