-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade design system / frontend engine #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- install design system v3 and frontend engine v2 - install new peer dependencies - resolve peer dependency conflicts - regenerate package-lock
- resolve duplicated MediaQuery.MaxWidth.xl arising from desktopL and desktop4k sizes
- layout - replace transition - theme
qroll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-critical, but would be good to migrate these css properties too
- border
- border-radius
- transition (use Motion)
traced the issue to RHF issue #12691, it appears the yupResolver turned the entire form readOnly, this probably broke dnd-kit as it tries to mutate the value |
got a slightly different error for the dropdown, the radio is okay now though tried to clone in the bulk edit resolver but that had no effect, so it should be something else causing the problem |
…d revert previous fix
|
thanks for spotting the bug, after delving deeper, I found that the error is related to how immer is making the states immutable. turning freeze off via I didnt manage to find out the exact place causing the error though, even |
- apply via border util - ensure it is not overwritten by border utils - use radius token
src/components/element-editor/basic-details/common/options-child.styles.tsx
Outdated
Show resolved
Hide resolved
src/components/element-editor/basic-details/common/options-child.styles.tsx
Outdated
Show resolved
Hide resolved
…fering with dashed border styling


Changes