Skip to content

Fix pdb install on Windows #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ribtoks wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix pdb install on Windows #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ if (LIBRAW_INSTALL)
if(NOT BUILD_SHARED_LIBS AND "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
message("ClangCl does not support pdb generation with static libraries")
elseif(MSVC)
install(FILES ${PROJECT_BINARY_DIR}/raw.pdb ${PROJECT_BINARY_DIR}/raw_r.pdb
install(FILES ${PROJECT_BINARY_DIR}/${CMAKE_BUILD_TYPE}/raw${CMAKE_DEBUG_POSTFIX}.pdb ${PROJECT_BINARY_DIR}/${CMAKE_BUILD_TYPE}/raw_r${CMAKE_DEBUG_POSTFIX}.pdb
Copy link
Collaborator

@letmaik letmaik Sep 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSVC is a multi-config generator in CMake for which CMAKE_BUILD_TYPE is not defined/used. See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html.

Copy link
Author

@ribtoks ribtoks Sep 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just used this code and it worked for me. Do you know what should be used instead?

DESTINATION ${CMAKE_INSTALL_LIBDIR}
CONFIGURATIONS Debug RelWithDebInfo
)
Expand Down