Skip to content

refactor : SecurityConfig 화이트리스트 수정#79

Merged
Juhye0k merged 1 commit intodevfrom
sql
Sep 24, 2025
Merged

refactor : SecurityConfig 화이트리스트 수정#79
Juhye0k merged 1 commit intodevfrom
sql

Conversation

@Juhye0k
Copy link
Copy Markdown
Contributor

@Juhye0k Juhye0k commented Sep 24, 2025

What is this PR?🔍

  • SecurityConfig 화이트리스트 수정

Summary by CodeRabbit

  • Chores
    • 일부 공개 엔드포인트의 무인증 접근을 해제하여 인증이 필요하도록 조정했습니다.
    • 미션 관련 콜백·이벤트 및 인증 토큰 관련 경로가 더 이상 공개되지 않습니다.
    • 사용자 영향: 로그인/토큰 없이 접근 시 401/403 응답이 반환될 수 있습니다.
    • 관련 연동(웹훅·콜백) 사용자는 사전 인증 또는 토큰 설정을 점검해 주세요.
    • 그 외 공개 엔드포인트는 기존과 동일하게 동작합니다.

event 요청에는 화이트리스트 필요 x
@Juhye0k Juhye0k merged commit 1083934 into dev Sep 24, 2025
1 of 2 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

보안 설정의 공개(permitAll) 엔드포인트 목록에서 미션 콜백 2종과 오타가 있는 인증 토큰 엔드포인트를 제거하여, 해당 경로들이 인증 없이 접근 불가하도록 변경했습니다. 다른 공개 엔드포인트는 유지되었습니다.

Changes

Cohort / File(s) Summary of Changes
Security config (permitAll 축소)
src/main/java/avengers/lion/global/config/security/SecurityConfig.java
공개 엔드포인트에서 "/api/v1/missions/*/callback", "/api/v1/missions/analyze/*/events", "/api/v1/auth/toekn" 제거. 결과적으로 이들 경로는 인증 필요로 전환. 기타 공개 경로는 기존과 동일.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant C as Client
    participant F as Spring Security FilterChain
    participant A as AuthenticationManager
    participant Ctrl as Controller

    Note over F: requestMatchers(permitAll) 목록 축소됨
    C->>F: HTTP 요청 (예: /api/v1/missions/*/callback)
    alt 경로가 permitAll에 포함됨
        F-->>C: 통과 (인증 불필요)
        C->>Ctrl: 요청 처리
        Ctrl-->>C: 응답
    else 경로가 permitAll에서 제거됨
        F->>A: 인증 처리
        alt 인증 성공
            A-->>F: 인증 객체
            F->>Ctrl: 요청 전달
            Ctrl-->>C: 응답
        else 인증 실패
            F-->>C: 401/403 응답
        end
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • chore : swagger 보안 수정 #18 — 동일한 SecurityConfig.javarequestMatchers/permitAll 구성을 다루며 Swagger 엔드포인트 추가를 포함해 공개 범위를 조정하는 변경과 직접적으로 연관.

Poem

깡총깡총, 나는 코드래빗
문은 세 개, 이제 두드려야 해—토큰 준비됐지?
콜백 길은 닫히고, 경비는 꼼꼼히
스프링 숲에 바람이 분다, 필터가 속삭이지
보안의 울타리, 오늘도 단단히 🥕

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sql

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27e766e and c91fcd7.

📒 Files selected for processing (1)
  • src/main/java/avengers/lion/global/config/security/SecurityConfig.java (1 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seo-bo
Copy link
Copy Markdown

seo-bo commented Sep 24, 2025

큰 레니

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants