Conversation
Using panic for license termination allowed recovery middleware to catch the failure, causing the app to continue running unlicensed. os.Exit(1) ensures the process terminates regardless of recovery middleware, so Docker can restart the container to retry license validation. X-Lerian-Ref: 0x1
Deduplicates the os.Exit subprocess test pattern from TestDefaultHandler and TestTerminateSafe_WithDefaultHandler into a reusable runSubprocessTest t.Helper. X-Lerian-Ref: 0x1
…ler-shutdown-behaviour Hotfix/replace default handler shutdown behaviour
…ix-vulnerability fix: bump go version to fix vulnerability GO-2026-4337
ClaraTersi
approved these changes
Mar 20, 2026
gandalf-at-lerian
approved these changes
Mar 20, 2026
Contributor
gandalf-at-lerian
left a comment
gandalf-at-lerian
left a comment
There was a problem hiding this comment.
LGTM. This is a conflict resolution bringing two main hotfixes into develop:
- fix(license):
panic→os.Exit(1)inDefaultHandler— correct call.paniccan be caught by recovery middleware, letting the app continue unlicensed.os.Exit(1)is unrecoverable, ensuring Docker restarts and retries license validation. - fix: Go version bump for GO-2026-4337 vulnerability — necessary.
- refactor: test helper extraction — clean dedup.
No net diff, pure merge resolution. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Pull Request Type
Checklist
Please check each item after it's completed.
Additional Notes
Obs: Please, always remember to target your PR to develop branch instead of main.