Skip to content

fix(client): update tenant-manager endpoint from /services/ to /associations/#373

Merged
ClaraTersi merged 1 commit intodevelopfrom
fix/tenant-manager-associations-path
Mar 20, 2026
Merged

fix(client): update tenant-manager endpoint from /services/ to /associations/#373
ClaraTersi merged 1 commit intodevelopfrom
fix/tenant-manager-associations-path

Conversation

@jeffersonrodrigues92
Copy link
Contributor

Summary

Tenant-manager consolidated all tenant-scoped routes under /associations/ (LerianStudio/tenant-manager#134). The lib-commons client still called the old /services/ path, causing 404 → "tenant not found" errors.

Change

  • client.go line 470: /v1/tenants/{id}/services/{svc}/connections/v1/tenants/{id}/associations/{svc}/connections
  • Test assertion updated to match

Test plan

  • go test ./commons/tenant-manager/... -count=1 — all pass

…iations/

Tenant-manager consolidated all tenant-scoped routes under /associations/ (issue #134). Updates the connections endpoint path to match.

X-Lerian-Ref: 0x1
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a1c7d9b8-77b0-467b-874d-c47c67b0eb93

📥 Commits

Reviewing files that changed from the base of the PR and between d5a82cb and e63bdd4.

📒 Files selected for processing (2)
  • commons/tenant-manager/client/client.go
  • commons/tenant-manager/client/client_test.go

Walkthrough

The GetTenantConfig method in the Tenant Manager client was updated to call a different API endpoint path. The request URL changed from calling /v1/tenants/{tenantID}/services/{service}/connections to /v1/tenants/{tenantID}/associations/{service}/connections. The corresponding unit test was updated to verify the new endpoint path is being called correctly.

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides context (related upstream change), specific file changes with line numbers, and test verification results. However, it does not follow the repository's PR template structure with checklist items. Consider following the repository's PR template with the Pull Request Type and Checklist sections to ensure consistency with project standards.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating a tenant-manager endpoint path from /services/ to /associations/, which matches the core modification in both client.go and the test file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ClaraTersi ClaraTersi merged commit ecc1979 into develop Mar 20, 2026
3 checks passed
@ClaraTersi ClaraTersi deleted the fix/tenant-manager-associations-path branch March 20, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants