Skip to content

Doc/mac m1 setup review#639

Open
fcipollone-ledger wants to merge 3 commits intomasterfrom
doc/mac-m1-setup-review
Open

Doc/mac m1 setup review#639
fcipollone-ledger wants to merge 3 commits intomasterfrom
doc/mac-m1-setup-review

Conversation

@fcipollone-ledger
Copy link
Copy Markdown

Before this PR, the instructions on this page did not work

  • Reviewed and tested the setup of Speculor on a Mac M1.
  • Added a script method
  • Restructured the headings, adding a Run Speculos heading

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 5, 2026

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.71%. Comparing base (dcd29c7) to head (3a3bc05).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #639   +/-   ##
=======================================
  Coverage   40.71%   40.71%           
=======================================
  Files         132      132           
  Lines       14215    14215           
  Branches     1275     1275           
=======================================
  Hits         5787     5787           
  Misses       8046     8046           
  Partials      382      382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@mbrousset-ledger mbrousset-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fcipollone-ledger,

Any reason to not use official image ? It was built for both amd64 and arm64 :
https://github.com/ledgerhq/speculos/pkgs/container/speculos/605003956?tag=0.25.13

We want to avoid having custom builds here and there. If a custom image is needed by teams, it may make sense to publish an additional image instead ?

cc @tdejoigny-ledger

@tdejoigny-ledger
Copy link
Copy Markdown
Contributor

@mbrousset-ledger I confirm that we don't want that the user rebuild the docker image, the user SHALL use the latest version of the docker image.

@tdejoigny-ledger
Copy link
Copy Markdown
Contributor

cc: @yogh333 for the mac env

@fcipollone-ledger
Copy link
Copy Markdown
Author

Hello @tdejoigny-ledger, @mbrousset-ledger @yogh333 , -
The current page gives instructions to build
https://github.com/LedgerHQ/speculos/blob/master/docs/user/macm1.md
Did you want to modify the existing page first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants