Skip to content

Proposal for #236#237

Draft
kingofpayne wants to merge 1 commit intomasterfrom
api-client-apdu-sw-improvement
Draft

Proposal for #236#237
kingofpayne wants to merge 1 commit intomasterfrom
api-client-apdu-sw-improvement

Conversation

@kingofpayne
Copy link
Copy Markdown
Contributor

No description provided.

@kingofpayne kingofpayne marked this pull request as draft July 30, 2021 13:23
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 30, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.59%. Comparing base (96875a8) to head (83e3e2d).
⚠️ Report is 810 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   55.59%   55.59%           
=======================================
  Files          67       67           
  Lines        6313     6313           
=======================================
  Hits         3510     3510           
  Misses       2803     2803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kingofpayne kingofpayne force-pushed the api-client-apdu-sw-improvement branch 4 times, most recently from 100e51c to d49b0cc Compare July 30, 2021 13:50
@kingofpayne kingofpayne force-pushed the api-client-apdu-sw-improvement branch from d49b0cc to 83e3e2d Compare July 30, 2021 14:35
@kingofpayne kingofpayne marked this pull request as ready for review July 30, 2021 15:04
@kingofpayne kingofpayne marked this pull request as draft July 30, 2021 15:11
@kingofpayne
Copy link
Copy Markdown
Contributor Author

There's still an issue with this change: status word checking is not performed if data method of ApduResponse is not called.

@lpascal-ledger lpascal-ledger changed the base branch from develop to master May 30, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants