add option --get-stack-consumption by mbrousset-ledger · Pull Request #268 · LedgerHQ/ragger

mbrousset-ledger · 2026-03-19T14:31:24Z

Adding a fixture to retrieve peak stack consumption in a test sequence.

⚠️ requires the app to be compiled with the following flags : DEBUG=1 DEBUG_OS_STACK_CONSUMPTION=1

Now test sequences print a stack consumption summary :

...
================================================== stack consumption summary ==================================================
      1185 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_exception_nodisplay[flex]
      1353 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_non_standard[flex-flex]
      1497 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_non_standard_reject[flex-flex]
      1497 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_non_standard_reject_early[flex-flex]
      1497 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_nonstandard_display[flex-flex]
       681 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_nonstandard_nodisplay[flex]
      1497 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_standard_display[flex-flex]
      1185 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_standard_nodisplay[flex]
--------- worst case: 1497 bytes  (test_get_extended_pubkey.py::test_get_extended_pubkey_standard_display[flex-flex]) ---------
======================================= 8 passed, 168 deselected, 7 warnings in 28.75s ========================================

The above example is an app-bitcoin-new test run of :

 source /opt/venv/bin/activate && pytest tests -k get_extended_pubkey --device flex --backend speculos --get-stack-consumption

codecov-commenter · 2026-03-31T11:30:16Z

Codecov Report

❌ Patch coverage is 34.21053% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.55%. Comparing base (04943af) to head (d4909e6).

Files with missing lines	Patch %	Lines
src/ragger/conftest/base_conftest.py	34.21%	25 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   78.32%   77.55%   -0.77%     
==========================================
  Files          36       36              
  Lines        2191     2228      +37     
==========================================
+ Hits         1716     1728      +12     
- Misses        475      500      +25

Flag	Coverage Δ
apex_p-py3.10	`77.46% <34.21%> (-0.77%)`	⬇️
apex_p-py3.11	`77.46% <34.21%> (-0.77%)`	⬇️
apex_p-py3.12	`77.46% <34.21%> (-0.77%)`	⬇️
apex_p-py3.13	`77.46% <34.21%> (-0.77%)`	⬇️
apex_p-py3.9	`?`
flex-py3.10	`77.46% <34.21%> (-0.77%)`	⬇️
flex-py3.11	`77.46% <34.21%> (-0.77%)`	⬇️
flex-py3.12	`77.46% <34.21%> (-0.77%)`	⬇️
flex-py3.13	`77.46% <34.21%> (-0.77%)`	⬇️
flex-py3.9	`?`
nanos-py3.10	`75.85% <34.21%> (-0.74%)`	⬇️
nanos-py3.11	`75.85% <34.21%> (-0.74%)`	⬇️
nanos-py3.12	`75.85% <34.21%> (-0.74%)`	⬇️
nanos-py3.13	`75.85% <34.21%> (-0.74%)`	⬇️
nanos-py3.9	`?`
nanosp-py3.10	`75.89% <34.21%> (-0.74%)`	⬇️
nanosp-py3.11	`75.89% <34.21%> (-0.74%)`	⬇️
nanosp-py3.12	`75.89% <34.21%> (-0.74%)`	⬇️
nanosp-py3.13	`75.89% <34.21%> (-0.74%)`	⬇️
nanosp-py3.9	`?`
nanox-py3.10	`75.85% <34.21%> (-0.74%)`	⬇️
nanox-py3.11	`75.85% <34.21%> (-0.74%)`	⬇️
nanox-py3.12	`75.85% <34.21%> (-0.74%)`	⬇️
nanox-py3.13	`75.85% <34.21%> (-0.74%)`	⬇️
nanox-py3.9	`?`
stax-py3.10	`77.46% <34.21%> (-0.77%)`	⬇️
stax-py3.11	`77.46% <34.21%> (-0.77%)`	⬇️
stax-py3.12	`77.46% <34.21%> (-0.77%)`	⬇️
stax-py3.13	`77.46% <34.21%> (-0.77%)`	⬇️
stax-py3.9	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

iartemov-ledger · 2026-03-31T16:45:56Z

⚠️ requires the app to be compiled with the following flags : DEBUG=1 DEBUG_OS_STACK_CONSUMPTION=1

It is not enough to pass the flag as environment variable - it's not handled by the SDK.
To make it work I had to add following line in the Makefile of app-bitcoin-new:

CFLAGS   += -DDEBUG_OS_STACK_CONSUMPTION=1

src/ragger/conftest/base_conftest.py

mbrousset-ledger · 2026-03-31T17:35:22Z

⚠️ requires the app to be compiled with the following flags : DEBUG=1 DEBUG_OS_STACK_CONSUMPTION=1

It is not enough to pass the flag as environment variable - it's not handled by the SDK. To make it work I had to add following line in the Makefile of app-bitcoin-new:
CFLAGS   += -DDEBUG_OS_STACK_CONSUMPTION=1

yes, i need to update the SDK

iartemov-ledger · 2026-04-01T07:49:12Z

⚠️ requires the app to be compiled with the following flags : DEBUG=1 DEBUG_OS_STACK_CONSUMPTION=1

It is not enough to pass the flag as environment variable - it's not handled by the SDK. To make it work I had to add following line in the Makefile of app-bitcoin-new:
CFLAGS   += -DDEBUG_OS_STACK_CONSUMPTION=1
yes, i need to update the SDK

LedgerHQ/ledger-secure-sdk#1480.

src/ragger/conftest/base_conftest.py

sonarqubecloud · 2026-04-01T13:30:31Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

iartemov-ledger

The maximum search works:

======================================================================================== stack consumption summary =========================================================================================
      1177 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_exception_nodisplay[flex]
      1193 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_non_standard[flex-flex]
      1281 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_non_standard_reject[flex-flex]
      1281 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_non_standard_reject_early[flex-flex]
      1281 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_nonstandard_display[flex-flex]
       673 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_nonstandard_nodisplay[flex]
      1281 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_standard_display[flex-flex]
      1177 bytes  test_get_extended_pubkey.py::test_get_extended_pubkey_standard_nodisplay[flex]
----------------------------------------------- worst case: 1281 bytes  (test_get_extended_pubkey.py::test_get_extended_pubkey_standard_display[flex-flex]) ------------------------------------------------

A fix will be done in the SDK to make it work with DEBUG=0.

Maybe to pat attention to the Copilot remark below.

mbrousset-ledger force-pushed the mbr/stack-fixture branch from e2c0f34 to e286c16 Compare March 31, 2026 08:58

mbrousset-ledger changed the title ~~add fixture to retrieve stack consumption~~ add option --get-stack-consumption Mar 31, 2026

mbrousset-ledger force-pushed the mbr/stack-fixture branch from e286c16 to 4130664 Compare March 31, 2026 11:27

mbrousset-ledger force-pushed the mbr/stack-fixture branch from 4130664 to 51bcb5d Compare March 31, 2026 12:29

remove support for python 3.10

c22e6ef

mbrousset-ledger force-pushed the mbr/stack-fixture branch 2 times, most recently from 55bbd5f to 2f534e8 Compare March 31, 2026 12:55

mbrousset-ledger requested review from cedelavergne-ledger, fbeutin-ledger and iartemov-ledger March 31, 2026 13:00

mbrousset-ledger marked this pull request as ready for review March 31, 2026 13:12

mbrousset-ledger force-pushed the mbr/stack-fixture branch from 2f534e8 to 3dc8cc7 Compare March 31, 2026 13:54

iartemov-ledger reviewed Mar 31, 2026

View reviewed changes

src/ragger/conftest/base_conftest.py Outdated Show resolved Hide resolved

mbrousset-ledger force-pushed the mbr/stack-fixture branch 2 times, most recently from a4d6ffc to aa33361 Compare April 1, 2026 11:37

github-advanced-security bot found potential problems Apr 1, 2026

View reviewed changes

src/ragger/conftest/base_conftest.py Fixed Show fixed Hide fixed

add fixture to retrieve stack consumption

d4909e6

mbrousset-ledger force-pushed the mbr/stack-fixture branch from 1d46321 to d4909e6 Compare April 1, 2026 13:29

iartemov-ledger approved these changes Apr 2, 2026

View reviewed changes

mbrousset-ledger merged commit 8968d26 into master Apr 2, 2026
53 checks passed

mbrousset-ledger deleted the mbr/stack-fixture branch April 2, 2026 07:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add option --get-stack-consumption#268

add option --get-stack-consumption#268
mbrousset-ledger merged 2 commits intomasterfrom
mbr/stack-fixture

mbrousset-ledger commented Mar 19, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Mar 31, 2026 •

edited

Loading

Uh oh!

iartemov-ledger commented Mar 31, 2026

Uh oh!

Uh oh!

mbrousset-ledger commented Mar 31, 2026

Uh oh!

iartemov-ledger commented Apr 1, 2026

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 1, 2026

Uh oh!

iartemov-ledger left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mbrousset-ledger commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

iartemov-ledger commented Mar 31, 2026

Uh oh!

Uh oh!

mbrousset-ledger commented Mar 31, 2026

Uh oh!

iartemov-ledger commented Apr 1, 2026

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 1, 2026

Quality Gate passed

Uh oh!

iartemov-ledger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mbrousset-ledger commented Mar 19, 2026 •

edited

Loading

codecov-commenter commented Mar 31, 2026 •

edited

Loading