add 2 new functions swapExactAmountInPro and swapExactAmountOutPro#40
Closed
tdejoigny-ledger wants to merge 1 commit intodevelopfrom
Closed
add 2 new functions swapExactAmountInPro and swapExactAmountOutPro#40tdejoigny-ledger wants to merge 1 commit intodevelopfrom
tdejoigny-ledger wants to merge 1 commit intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Velora (Paraswap) plugin support for Augustus v6.2 “Pro Partner” swap methods on Ethereum, including selector registration, parameter parsing, UI labels, test vectors, and network metadata/ABI needed for transaction resolution.
Changes:
- Register and recognize two new selectors:
swapExactAmountInPro(0x0d893d62) andswapExactAmountOutPro(0x44224add). - Parse/display the new call data fields in the plugin UI flow (Send / Receive, including beneficiary handling).
- Add Ethereum network test configuration + ABI and two new snapshot-driven tests.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/src/eth/v6/swap_exact_amount_out_pro.test.ts | Adds snapshot test for swapExactAmountOutPro calldata. |
| tests/src/eth/v6/swap_exact_amount_in_pro.test.ts | Adds snapshot test for swapExactAmountInPro calldata. |
| tests/networks/ethereum/paraswap/b2c.json | Registers new contract + selectors for test-time plugin resolution. |
| tests/networks/ethereum/paraswap/abis/0x6a000f20005980200259b80c5102003040001068.abi.json | Adds ABI for the Augustus v6.2 contract used by tests/resolution. |
| src/plugin.h | Increases selector count and adds enum entries for the new methods. |
| src/handle_query_contract_ui.c | Adds UI title mapping for the new selectors. |
| src/handle_query_contract_id.c | Adds contract ID version mapping for the new selectors. |
| src/handle_provide_parameter.c | Adds calldata parsing logic for the new methods’ parameter layout. |
| src/handle_init_contract.c | Initializes parsing state for the new selectors (skipping executor). |
| src/handle_finalize.c | Includes new selectors in beneficiary-screen decision logic. |
| src/contract.c | Adds selector constants and appends them to PARASWAP_SELECTORS. |
| Makefile | Bumps app version from 2.5.0 to 2.6.0. |
| CHANGELOG.md | Documents the new methods/contract support and tests in 2.6.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
13e2137 to
24d1157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec available here : https://paraswap.notion.site/Velora-Pro-Partner-methods-321dea6b80b7809fbc73caead6c63fc4 and here https://developers.velora.xyz/augustus-swapper/augustus-v6.2-smart-contracts
Checklist
develop