-
Notifications
You must be signed in to change notification settings - Fork 7
Merge develop into master (B2CA-2351) #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
bb2010d
d2fcc30
4ea696d
74b6dbf
78bd956
f1bf2aa
48a4867
7d3914f
8e15548
4c6ff97
2d446a0
a5e9876
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| BasedOnStyle: Google | ||
| IndentWidth: 4 | ||
| Language: Cpp | ||
| ColumnLimit: 100 | ||
| PointerAlignment: Right | ||
| AlignAfterOpenBracket: Align | ||
| AlignConsecutiveMacros: true | ||
| AllowAllParametersOfDeclarationOnNextLine: false | ||
| SortIncludes: false | ||
| SpaceAfterCStyleCast: true | ||
| AllowShortCaseLabelsOnASingleLine: false | ||
| AllowAllArgumentsOnNextLine: false | ||
| AllowShortBlocksOnASingleLine: Never | ||
| AllowShortFunctionsOnASingleLine: None | ||
| BinPackArguments: false | ||
| BinPackParameters: false | ||
| --- |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: Build and run functional tests using ragger through reusable workflow | ||
|
|
||
| # This workflow will build the app and then run functional tests using the Ragger framework upon Speculos emulation. | ||
| # It calls a reusable workflow developed by Ledger's internal developer team to build the application and upload the | ||
| # resulting binaries. | ||
| # It then calls another reusable workflow to run the Ragger tests on the compiled application binary. | ||
| # | ||
| # The build part of this workflow is mandatory, this ensures that the app will be deployable in the Ledger App Store. | ||
| # While the test part of this workflow is optional, having functional testing on your application is mandatory and this workflow and | ||
| # tooling environment is meant to be easy to use and adapt after forking your application | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| golden_run: | ||
| type: choice | ||
| required: true | ||
| default: "Raise an error (default)" | ||
| description: CI behavior if the test snapshots are different than expected. | ||
| options: | ||
| - "Raise an error (default)" | ||
| - "Open a PR" | ||
| push: | ||
| branches: | ||
| - master | ||
| - main | ||
| - develop | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| build_application: | ||
| name: Build application using the reusable workflow | ||
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_build.yml@v1 | ||
| with: | ||
| upload_app_binaries_artifact: "app_boilerplate_binaries" | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,25 @@ | ||||||||||||||||||||||||||
| name: Run coding style check through reusable workflow | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # This workflow will run linting checks to ensure a level of uniformization among all Ledger applications. | ||||||||||||||||||||||||||
| # | ||||||||||||||||||||||||||
| # The presence of this workflow is mandatory as a minimal level of linting is required. | ||||||||||||||||||||||||||
| # You are however free to modify the content of the .clang-format file and thus the coding style of your application. | ||||||||||||||||||||||||||
| # We simply ask you to not diverge too much from the linting of the Boilerplate application. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| on: | ||||||||||||||||||||||||||
| workflow_dispatch: | ||||||||||||||||||||||||||
| push: | ||||||||||||||||||||||||||
| branches: | ||||||||||||||||||||||||||
| - master | ||||||||||||||||||||||||||
| - main | ||||||||||||||||||||||||||
| - develop | ||||||||||||||||||||||||||
| pull_request: | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| jobs: | ||||||||||||||||||||||||||
| check_linting: | ||||||||||||||||||||||||||
| name: Check linting using the reusable workflow | ||||||||||||||||||||||||||
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_lint.yml@v1 | ||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||
| source: "./src" | ||||||||||||||||||||||||||
| extensions: "h,c" | ||||||||||||||||||||||||||
| version: 18 | ||||||||||||||||||||||||||
|
Comment on lines
+20
to
+25
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
Copilot AutofixAI 6 months ago To address this issue, add a
Suggested changeset
1
.github/workflows/coding_style_checks.yml
Copilot is powered by AI and may make mistakes. Always verify output.
Refresh and try again.
|
||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| bin | ||
| build | ||
| debug | ||
| dep | ||
| obj | ||
| output-scan-build | ||
| .vscode | ||
| src/glyphs.c | ||
| src/glyphs.h | ||
| customCA.key |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 6 months ago
To fix the issue, add an explicit
permissionsblock to the workflow. The most robust practice is to set permissions at the workflow root so they apply to all jobs unless a specific job needs an override. The required permissions are typically minimal—contents: readis safe for builds that simply need access to the repository source, and if artifact uploads or pull requests are handled, additional permissions might be needed (e.g.,pull-requests: write). For this workflow, which builds applications and uploads binaries but does not appear to create PRs directly,contents: readshould suffice for a starting point. Add the following block after the workflow name (aboveon:):If later steps require additional permissions, these can be added.
Change to make:
In
.github/workflows/build_and_functional_tests.yml, insert the above block after line 1 (following the workflow name and before theon:block).