refactor: throw GearError with more information to help debugging #187
Conversation
🦋 Changeset detectedLatest commit: ef158e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying malib-docs with
|
| Latest commit: |
ef158e5
|
| Status: | 🚫 Build failed. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| * @param gear 초기화할 장비. | ||
| * | ||
| * @throws {@link TypeError} | ||
| * @throws {@link GearError} |
There was a problem hiding this comment.
Bug: Inconsistent error type for invalid options in setPotential
The setPotential function throws TypeError for invalid options.length, but the equivalent validation in setAdditionalPotential was updated to throw GearError with detailed debugging information. This appears to be an incomplete refactoring, since the PR's intent is to throw GearError with more information for debugging. The functions now have inconsistent error handling behavior for the same type of validation failure.
Additional Locations (1)
refactor: throw GearError with more information to help debugging
Note
Replace TypeError usages across gear APIs with GearError (with gear/status context) and introduce _DeferredGearError; update docs/tests accordingly.
GearError(includesgearId,gearName, andstatus).TypeErrorwithGearErroracrossGearmethods and enhance modules; useRangeErrorfor value range checks where appropriate._DeferredGearErrorto compute values context-free and rethrow asGearError; updateapply/reset/get*to throwGearErrorwith status.starforce,starScroll,resetStarforce,recalculateStarforcenow throwGearErrorwith detailed status; internal_getValuelikewise.failScroll,resileScroll,resetUpgrade,applyScrollnow throwGearErrorwith status.GearErrorwith status; add glove handling ingetSpellTraceScroll.set/resetPotential,set/resetAdditionalPotentialthrowGearError(andRangeErrorfor invalid grades).applySoulEnchant,setSoul,setSoulChargethrowGearError(andRangeErrorfor invalid charge).GearErrorinstead ofTypeErrorthroughout.GearError/RangeError; add coverage for_DeferredGearErrorpaths.Written by Cursor Bugbot for commit ef158e5. This will update automatically on new commits. Configure here.