Dev #20
Open
Dev #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- passed missing $id_shop to the getLangLink and createUrl methods - remove only root and current category from the URL Tested on PrestaShop v1.5.6.1. Now working fine!
canonicalRedirection has to remove rewrite ids from _GET before redirect, as it does in the FrontController for ordinary id_*
// sync base
BIG Fixed: Configuration::get('PS_ROOT_CATEGORY') has to be used *after* parent constructor has been invoked
Better implementation. Do exactly what we want, not what is supposed to give the same result
hack to make smartblog category path work. Remember to deactivate html in the smartblog module configuration
works on prestashop 1.6.0.9
argh that semicolon...
Meta keywords and title can be passed to the function as an array or string. This update ensures that the array is flatened to a single string prior to asking Tools:str2url to work with it. If Tools::str2url recieves an array it throws our lots of 'Warning' messages when PHP debugging is enabled in PS. merged from mrtwister76 mrtwister76/PrestaShop-modules-CleanURLs@0b50f2a
make getCategoryLink compatible with new prestashop 1.6.0.12
added addRoute function to the override on ps 1.6.0.11 var $regex has changed to '#^/'.$regexp.'$#u' changed back to '#^/'.$regexp.'(\?.*)?$#u' so now cleanurl cart, login, quickview and pagination, basically whenever there's a ? in the url works again
- allow id, ean13 and oter parameters - a bit of code simplification - fixed regex greediness and double preg_quote bug by overriding core method
Close #63
- required sensiolabs/security-checker - created some useful composer script stanzas - updated versions - changed bin-dir to "bin"
- closes #61 - closes #62 - closes #63
* Migrate the module to the new Faktiva maintainer * minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
First thanks for this module that works great!
I have a question.
My new URLS are like:
http://www.jmbarrachina.com/bolsas/bolsa-larsen
Is posible to accept also my old URLS like?
http://www.jmbarrachina.com/bolsas/100003322-bolsa-larsen.html
The ID of the product now is not the same, but the rewrite in product_lang is the same 'bolsa-larsen'
Thanks, best regards
Juan