Open
Conversation
Many changes from following branches into one 1. serafin-1082 1. serafin-1082-attempt-2 1. patrick-serafin-1082 1. jorge-serafin-1082 1. serafin-1082-attempt-3 1. merge-test
…t instead of named exports
- as of this commit - all tests passing Removes unneeded console log
because models is being generated dynamically
Tests still passing
Ran full tests - all tests passing
All tests passing
All tests passing
All tests passing
heyheyjp
requested changes
Sep 21, 2017
Collaborator
heyheyjp
left a comment
There was a problem hiding this comment.
See tip on more concise exports from index.js files.
| getRetrospectiveSurvey, | ||
| getRetrospectiveSurveyQuestion, | ||
| getUser, | ||
| getUserSummary, |
Collaborator
There was a problem hiding this comment.
Protip: can accomplish this in half the lines:
export {default as findChapters} from './findChapters'
export {default as findMembers} from './findMembers'
export {default as findPhaseSummaries} from './findPhaseSummaries'
export {default as findPhases} from './findPhases'
export {default as findProjects} from './findProjects'
export {default as findProjectsForCycle} from './findProjectsForCycle'
export {default as findRetrospectiveSurveys} from './findRetrospectiveSurveys'
export {default as findUsers} from './findUsers'
export {default as getChapter} from './getChapter'
export {default as getCycleById} from './getCycleById'
export {default as getCycleVotingResults} from './getCycleVotingResults'
export {default as getMemberById} from './getMemberById'
export {default as getProject} from './getProject'
export {default as getProjectSummary} from './getProjectSummary'
export {default as getProjectSummaryForMember} from './getProjectSummaryForMember'
export {default as getRetrospectiveSurvey} from './getRetrospectiveSurvey'
export {default as getRetrospectiveSurveyQuestion} from './getRetrospectiveSurveyQuestion'
export {default as getUser} from './getUser'
export {default as getUserSummary} from './getUserSummary'
Author
There was a problem hiding this comment.
Making this switch leads to 49 failing tests on my end. Have tried a variety of ways of exporting and have not found a workable solution.
Collaborator
There was a problem hiding this comment.
Got it. I'll have a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1082
Overview
Reduces over 400 linting warnings down to 12 linting warnings
Most coming from 'import/named' and 'prefer-default-export'
This changes imports and exports to be static
Also removes autoloader and replaces with static list of imports and exports for entire folder structure
Data Model / DB Schema Changes
N/A
Environment / Configuration Changes
Removes 'keymirror' and 'autoloader' from package.json
Notes