Change suffix optimization to use theory-based restrictions #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x to reveal registers
pfg666
requested changes
Jun 27, 2024
Collaborator
pfg666
left a comment
pfg666
left a comment
There was a problem hiding this comment.
How we build the SymbolicSuffixRestrictionBuilder is not quite right. How about adding a method to the TreeOracle which returns it, and calling this method e.g., from with RaLambda to build it?
E.g., getSymbolicSuffixRestrictionBuilder()
Other than that, I think we can merge.
Collaborator
There was a problem hiding this comment.
Would be useful to have some basic documentation on the purpose of this class.
| return new SDT(sdtChildren); | ||
| } | ||
|
|
||
| public LabeledSDT get(int l) { |
Collaborator
There was a problem hiding this comment.
Get what? Perhaps getLabeledSDT,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suffix optimization was hard-coded in the SymbolicSuffix class to only use optimizations for equality between suffix parameters and fresh parameters. This would make it very difficult to add new optimizations and optimizations for theories other than equality.
This PR changes the way suffix optimization is implemented such that theory-specific restrictions can be placed on suffix parameters. This is handled by the theories themselves, and the SymbolicSuffix class is now agnostic of which kinds of restrictions are available.
In addition, this change in suffix optimization also fixes a long-standing and, until recently, undetected bug where optimization for equality between suffix values would still be used, even if suffix optimization was disabled.