Add typestate write operations to ProtonClient#17
Merged
dannywillems merged 2 commits intomasterfrom Feb 9, 2026
Merged
Conversation
Introduce a type parameter M on ProtonClient<M> that controls access at compile time: - ProtonClient<ReadOnly> (default): read operations only - ProtonClient<ReadWrite>: read + write operations Write operations added: move_to_folder, add_flag, remove_flag, archive, unmark_all_read. Extract shared TLS/connection logic into connection.rs and add Flag enum in flag.rs. Update fake IMAP server to support STORE, COPY, and EXPUNGE commands with Arc<Mutex<Mailbox>> for shared mutable state. Add integration tests for all write operations.
dannywillems
force-pushed
the
add-typestate-write-operations
branch
2 times, most recently
from
a20bce0 to
d8dd154
Compare
Add three compile_fail doctests proving ProtonClient<ReadOnly> cannot call write methods (add_flag, move_to_folder, archive). The main module doctest keeps no_run since it calls from_env() which requires IMAP env vars at runtime. Remove all #[allow(clippy::...)] annotations by fixing the underlying issues: extract dispatch_command to reduce line count, introduce StoreArgs struct to reduce argument count, and inline MutexGuard usage to satisfy significant_drop_tightening.
dannywillems
force-pushed
the
add-typestate-write-operations
branch
from
49c8674 to
51341f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProtonClient<M>whereMisReadOnly(default) orReadWrite, enforcing access control at compile timemove_to_folder,add_flag,remove_flag,archive,unmark_all_read(only available onProtonClient<ReadWrite>)connection.rsand addFlagenum inflag.rsSTORE,COPY,EXPUNGEhandlers andArc<Mutex<Mailbox>>for mutable stateTest plan
cargo test)cargo clippy --all-targets)cargo +nightly fmt -- --check)