Fix RFC 3501 compliance issues in fake IMAP server#16
Merged
dannywillems merged 1 commit intomasterfrom Feb 9, 2026
Merged
Conversation
- SELECT: add FLAGS, RECENT, PERMANENTFLAGS, UIDNEXT, UNSEEN responses (#4, #5, #9, #10, #11) - Add CAPABILITY and NOOP command handlers (#6, #7) - Make INBOX lookup case-insensitive in get_folder() (#8) - Add human-readable text to BYE response (#12) - Use 1-based sequence number instead of UID in FETCH (#13)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
* FLAGS,* <n> RECENT, and recommended* OK [PERMANENTFLAGS],* OK [UIDNEXT],* OK [UNSEEN]responses (Fake IMAP: SELECT missing required * <n> RECENT response #4, Fake IMAP: SELECT missing required * FLAGS response #5, Fake IMAP: SELECT missing PERMANENTFLAGS response #9, Fake IMAP: SELECT missing UIDNEXT response #10, Fake IMAP: SELECT missing UNSEEN response #11)get_folder()per RFC 3501 Section 5.1 (Fake IMAP: INBOX lookup is case-sensitive #8)Closes #4, closes #5, closes #6, closes #7, closes #8, closes #9, closes #10, closes #11, closes #12, closes #13
Test plan
cargo clippy --all-targetscleancargo +nightly fmt -- --checkclean