Use imap-codec for command parsing, add Folder enum#14
Merged
dannywillems merged 1 commit intomasterfrom Feb 9, 2026
Merged
Conversation
Replace ad-hoc string matching in the fake IMAP server with imap-codec's CommandCodec for strongly-typed IMAP command dispatch. Handlers now receive parsed types (SearchKey, SequenceSet, Mailbox) instead of raw strings, enabling reliable date-range filtering and easier addition of new query types. Add a Folder enum (Inbox, Sent, Drafts, Trash, Spam, Archive, Custom) to replace raw &str folder parameters across the public API, CLI, and test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imap-codec'sCommandCodecfor strongly-typed IMAP command dispatch — handlers now receive parsed types (SearchKey,SequenceSet,Mailbox) instead of raw stringsFolderenum (Inbox,Sent,Drafts,Trash,Spam,Archive,Custom(String)) insrc/folder.rsto replace raw&strfolder parameters across the public client API, CLI, and test suiteTest plan
cargo clippy --all-targetscleancargo +nightly fmt -- --checkclean