Split parser tests into focused files, add module docs#16
Merged
dannywillems merged 2 commits intomainfrom Feb 11, 2026
Merged
Conversation
Remove #[allow(clippy::module_inception)] by renaming the inner parser.rs to core.rs. Add comprehensive rustdoc to parser/mod.rs documenting supported SQL features, parsing approach, data types, and known limitations.
Replace the monolithic 2117-line test file with 12 topic-focused files sharing helpers via tests/common/mod.rs. All 154 tests are preserved verbatim. Files: parser_select_columns (10 tests), parser_select_from (18), parser_select_clauses (12), parser_insert (8), parser_update_delete (12), parser_literals (8), parser_operators (29), parser_expressions (14), parser_functions (18), parser_data_types (11), parser_complex (8), parser_errors (6).
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parser/parser.rstoparser/core.rsto remove#[allow(clippy::module_inception)]parser/mod.rsdocumenting supportedSQL syntax, parsing approach, data types, and limitations
parser_comprehensive.rs(2117 lines) into 12focused test files with shared helpers in
tests/common/mod.rsTest files
parser_select_columnsparser_select_fromparser_select_clausesparser_insertparser_update_deleteparser_literalsparser_operatorsparser_expressionsparser_functionsparser_data_typesparser_complexparser_errorsAll 154 tests preserved verbatim.
Test plan
cargo test -p oxide-sql-core— 154 tests passcargo clippy -p oxide-sql-core -- -D warnings— cleanmake check-trailing-whitespace— clean