Add comprehensive SQL parser integration tests#14
Merged
dannywillems merged 4 commits intomainfrom Feb 11, 2026
Merged
Conversation
Cover every parser feature: SELECT columns, FROM/JOIN, WHERE, GROUP BY, HAVING, ORDER BY, LIMIT/OFFSET, INSERT, UPDATE, DELETE, all operators, precedence, CASE, CAST, functions, subqueries, parameters, data types, and error cases.
Implement fmt::Display (using core::fmt) for every AST type so that parse(sql).to_string() produces valid, re-parseable SQL. Add a round_trip() helper to parser_comprehensive.rs that verifies the rendered output is a fixed point (parse -> render -> parse -> render produces identical strings). Fix DataType::Double to render as DOUBLE (was DOUBLE PRECISION which the parser cannot re-parse). Special-case EXISTS in FunctionCall Display to avoid double parentheses.
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/oxide-sql-core/tests/parser_comprehensive.rsTest plan
cargo test --test parser_comprehensive -p oxide-sql-core— 154 passedmake test— full suite passesmake lint— clippy clean